Conversation
…eature/DmitriyPrihodko1
# Conflicts: # README.md
| import java.io.IOException; | ||
|
|
||
| public class Main { | ||
| public static void main(String[] args) throws IOException { |
There was a problem hiding this comment.
The names of variables/methods/classes are not always chosen correctly and follow Code Conventions
There was a problem hiding this comment.
Well-done! The game is quite comfortable to play, it has a nice interface. Also, you show good knowledge of Java Core and Java libraries, mostly abstractions are chosen correctly, and the structure of the project is quite cool. Here and there are some minor Code Conventions violations, but in general the code is easy to read. Cool implementations of Speaker and Threads!
Approved
| | HW2 | [PyramidPrinter](./src/main/java/homework_2/pyramid_printer) <br/> :wrench:[PyramidPrinterTest](./src/test/java/homework_2/pyramid_printer)| App reads the number one time from the command line, and prints a pyramid of "x". | | ||
| | HW2 | [RandomCharsTable](./src/main/java/homework_2/random_chars_table) <br/> :wrench:[RandomCharsTableTest](./src/test/java/homework_2/random_chars_table)| App reads width and length of the table array, and strategy keyword (even or odd). App adds random chars from A to Z in table. Prints a table and all even or odd letters. | | ||
| | HW3 | [ImmutableClass](./src/main/java/homework_3)| ImmutableClass| | ||
| | HW4 | [CustomFileReader](./src/main/java/homework_4/custom_file_reader) <br/> :wrench:[CustomFileReaderTest](./src/test/java/homework_4/custom_file_reader)| This application reads the text from the file, removes commas and periods and them outputs the text to the console. | |
There was a problem hiding this comment.
Opt: are these still in progress?
src/main/java/homework_4/custom_file_reader/CustomFileReader.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private boolean regex(String readLine) { | ||
| if (readLine.length() < 3) return false; |
There was a problem hiding this comment.
Opt: avoid using if without brackets
| if (a == 0) return 0; | ||
| if (a == 1 || b == 0) return 1; | ||
| if (b == 1) return a; | ||
| return a * recursia(a, b - 1); |
src/main/java/homework_6/map_problems_generator/MapProblemsMutableGenerator.java
Outdated
Show resolved
Hide resolved
| Cat cat = new Cat("Myrka", 12); | ||
| Kitten tom = new Kitten("Tom", 3, "YYY"); | ||
|
|
||
| KittenToCatFunction kittenToCatFunction = kitten -> new Cat(kitten.getName() + "Cat", kitten.getAge() + 10); |
There was a problem hiding this comment.
Opt: you could try type conversion in lambda (as example, favourite toy to favourite color or smth like this)
| class RandomCharsTableTest extends UnitBase { | ||
|
|
||
| @Test | ||
| void given_first_bad() { |
There was a problem hiding this comment.
Opt: better if your test cases names follow given_when_then pattern, when can be omitted. Something like givenInvalid_thenRuntimeException
NikolaevArtem
left a comment
NikolaevArtem
left a comment
There was a problem hiding this comment.
Good! There are minor changes requested in HW, Course Project looks nice!
NikolaevArtem
added
HW_3
HW_4
HW_6
and removed
bug
4 participants
No description provided.